Unescape query parameter name #33401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
area-runtime
community-contribution
Tratcher
approved these changes
Jun 9, 2021
A little more test coverage would be appreciated. |
|
Sorry, I just realized this conflicts with #32829 that re-wrote a lot of this code to be more efficient. This bug still exists in that new code, so we'll prioritize getting that PR merged and then rebase this on top. Hold tight. |
campersau
force-pushed
the
unescapequeryparametername
branch
from
d6b0527
to
2301882
Compare
campersau
force-pushed
the
unescapequeryparametername
branch
from
2301882
to
b7acb25
Compare
|
@Tratcher updated the new code path and added tests for it. |
Tratcher
approved these changes
Jun 18, 2021
|
Thanks for getting back to this. |
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Title
Unescape query parameter name in QueryHelpers
PR Description
Unescapes the query parameter name when there is no value. This is already done when there was a value.
There are currently no test in QueryHelpersTests for testing encoded keys / values, should I add some more?
Fixes #33394